Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DeleteParams for delete_collection #53

Closed
clux opened this issue Jul 21, 2019 · 3 comments · Fixed by #308
Closed

add DeleteParams for delete_collection #53

clux opened this issue Jul 21, 2019 · 3 comments · Fixed by #308
Assignees
@clux
Labels
api Api abstraction related

Comments

@clux
Copy link
Member

clux commented Jul 21, 2019

We currently use ListParams but this is technically a bit wrong. See Arnavion/k8s-openapi#46
@clux clux added enhancement good first issue Good for newcomers help wanted Not immediately prioritised, please help! labels Dec 2, 2019
@ericmcbride
Copy link
Contributor

I can tackle this if still needed

@clux
Copy link
Member Author

clux commented Feb 5, 2020

Yes please. If you can figure out what's actually inconsistent. It's been a while since I reported this 😄

We currently have ListParams in the signature for delete_collection, but should probably have some sort of DeleteParams instead. Possibly with the preconditions that Arnavion talks about https://arnavion.github.io/k8s-openapi/v0.7.x/k8s_openapi/struct.DeleteOptional.html#structfield.preconditions

@clux clux removed the good first issue Good for newcomers label Feb 9, 2020
@clux clux added api Api abstraction related and removed enhancement labels Feb 26, 2020
clux added a commit that referenced this issue Aug 17, 2020
@clux
add DeleteParams to Api::delete_collection + use body params for it
d1729ad 
fixes #53.
@clux clux removed the help wanted Not immediately prioritised, please help! label Aug 17, 2020
@clux clux self-assigned this Aug 17, 2020
@clux clux linked a pull request Aug 17, 2020 that will close this issue
add DeleteParams to Api::delete_collection + use body params for it #308
Merged
@clux clux closed this as completed in #308 Aug 17, 2020
@clux
Copy link
Member Author

clux commented Aug 18, 2020

Fixed in 0.40.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clux clux

Labels
api Api abstraction related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add DeleteParams to Api::delete_collection + use body params for it kube-rs/kube
2 participants
@clux @ericmcbride