Fails to compile against k8s-openapi with the 1_22 feature

[lfrancke]

error[E0433]: failed to resolve: could not find `v1beta1` in `apiexts`
  --> /home/lars/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/kube-core-0.59.0/src/crd.rs:33:37
   |
33 |         fn crd() -> super::apiexts::v1beta1::CustomResourceDefinition;
   |                                     ^^^^^^^ could not find `v1beta1` in `apiexts`

https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes
The v1beta1 thing as been removed in 1.22.

[clux]

Ah. Right. Yup, that probably needs a feature workaround. Probably one of:

• gated on a v1_22 feature (but don't really want to introduce version features here)
• gated on the k8s-openapi feature (but don't think we can gate on features in other crates)
• gated behind a deprecated_apis feature

The last lets users explicitly opt in while they exist in k8s-openapi, without us having to track versions

[lfrancke]

Option two would be the "best" in terms of usability but if that doesn't work I'm in favor of the last option as well.

[nightkr]

AFAIK we can't see dependency features (and it would have the same issue where we need to maintain tables of which k8s versions support which features. I'd consider adding a `deprecated-crd-v1beta1` feature. That way: 1. Users get a clearish full error when the feature is fully removed 2. We don't have to care about which k8s removes or deprecates what 3. We can support multiple features at different stages of their deprecation cycles

…

On Tue, 10 Aug 2021, 13:41 Lars Francke, ***@***.***> wrote: Option two would be the "best" in terms of usability but if that doesn't work I'm in favor of the last option as well. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#621 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE6U2HES5RVCIMJAMHZGILT4EF5BANCNFSM5B35IMIA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[clux]

Started a PR for this in #622. Using the longer name feature as suggested, completely agree with that argument.