-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support v1_22 by feature gating crd v1beta1 #622
Conversation
slightly dodgy because we need to do one of: - pin k8s-openapi to v1_22 to test legacy features (tested in crd_api) - pin k8s-openapi to v1_21 and hope the legacy paths work (cant test) - build multiple k8s-openapi versions in CI maybe the latter is the best. can pin latest everywhere, and have examples lag behind as the only place to test legacy? Signed-off-by: clux <[email protected]>
For the testing, maybe it'd be enough to add the following commands to the test suite:
|
Hey there, is there any work that can be picked up here to help push this forward? I've looked a bit at the related issue and am currently running into the same issue on a project of mine when trying to upgrade to v1_22. I think being able to build/test against multiple versions of k8s_openapi in CI would be really nice. |
Yeah sorry, a bit busy atm. Insofar as functionality is concerned this branch is done so you can use a cargo git pin to test. Otherwise, I'll be back for a bit on Tuesday evening and can probably make a few tweaks to the testing strategy and get this in then. |
required a bit of re-jigging of re-exported features, but wont test everything with older k8s-openapi, just that example Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Decided on tracking latest version in master, so have fixed up unit tests in Also added a |
Ok, did some testing of this locally. The compile tests we run for k3d cluster create --servers 1 --agents 1 --image rancher/k3s:v1.20.10-k3s1
# export kubeconfig correctly and maybe use it with KUBECONFIG
cargo run --example crd_api --no-default-features --features=deprecated,native-tls,kubederive Satisfied that this at least works, so will merge this and leave the test to compile only on CI for now. |
Released in 0.60.0 :-) |
slightly dodgy because we need to do one of:
maybe the latter is the best. can pin latest everywhere, and have
examples lag behind as the only place to test legacy?