feat(runtime): support for owned shared streams #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added support for shared streams in the controller via a reflector. There are only two public interfaces available to thread a stream through a controller, `for_shared_stream` and `for_shared_stream_with`. For non-shared streams, the controller can compose with other types of streams that will trigger reconciliation, e.g. streams of owned objects, or custom streams that take mappers out-of-band. For parity, the controller should expose public interfaces to allow the same for shared streams. This change adds four new interfaces: * `owns_shared_stream` * `owns_shared_stream_with` * `watches_shared_stream` * `watches_shared_stream_with` The contract is the same as `for_shared_stream`. Accept a stream of `Arc<K>` and turn it into a reconciliation trigger. Signed-off-by: Matei David <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
=======================================
- Coverage 74.4% 74.1% -0.2%
=======================================
Files 78 78
Lines 6778 6801 +23
=======================================
Hits 5037 5037
- Misses 1741 1764 +23
|
clux
approved these changes
May 1, 2024
Signed-off-by: Matei David <[email protected]>
clux
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added support for shared streams in the controller via a reflector. There are only two public interfaces available to thread a stream through a controller,
for_shared_streamandfor_shared_stream_with.For non-shared streams, the controller can compose with other types of streams that will trigger reconciliation, e.g. streams of owned objects, or custom streams that take mappers out-of-band. For parity, the controller should expose public interfaces to allow the same for shared streams.
This change adds four new interfaces:
owns_shared_streamowns_shared_stream_withwatches_shared_streamwatches_shared_stream_withThe contract is the same as
for_shared_stream. Accept a stream ofArc<K>and turn it into a reconciliation trigger.