Follow up on WebSocket connection support

[kazk]

• Use re-exported native_tls
• Support config.accept_invalid_certs with ws-rustls-tls
• Run ws tests on Circle CI (mostly to make sure it compiles on both TLS)
• Remove catch all panic from WS connect
• Use doc_cfg on docs.rs (closes Use doc_cfg (#[doc(cfg(feature = "..."))]) to show feature requirements #365)
  • To try: cargo +nightly rustdoc --lib --features=derive,ws,ws-native-tls -- --cfg docsrs
• Fix broken links in docs
• Avoid panicking on connection failure (closes websocket connections can panic based on connection errors #369)

[clux]

comment on panics, but everything else looks great!

[kazk]

Should be ready for merge.

[clux]

Thanks! Looks great.
Left one last comment on the panic!, I am happy to backtrack on it if you still feel strongly about it.
But otherwise I'll merge it later on tonight.

[jbg]

I'm hitting a build error in this branch when using it as a dependency.

There seems to be an undeclared dependency on the io feature of tokio-util being enabled. I get this build error:

error[E0433]: failed to resolve: could not find `io` in `tokio_util`
   --> /cargo/git/checkouts/kube-rs-97ea51fe938f4d16/ed3f44d/kube/src/api/remote_command.rs:173:40
    |
173 |     let mut stdin_stream = tokio_util::io::ReaderStream::new(stdin);
    |                                        ^^ could not find `io` in `tokio_util`

... which is resolved by adding a dependency tokio-util = { version = "0.6", features = ["io"] } to my crate - kube should add the feature to its dependency.

[kazk]

@clux I think it's fine to have WsOther for now. Both WsOther and panic! on unexpected tungstenite::Error variant are hacks. Ideally, tungstenite should have a set of possible errors, so we know exactly what to expect and don't have to propagate this confusion to our users, but it doesn't. Returning WsOther will give our users a choice to ignore or panic depending on their need.

@jbg Thanks for letting us know. Fixed it.