-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow merging multi-version CRDs into a single schema #889
Conversation
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 70.25% 70.35% +0.09%
==========================================
Files 61 62 +1
Lines 4223 4264 +41
==========================================
+ Hits 2967 3000 +33
- Misses 1256 1264 +8
|
This should be pretty ready now. I have made it a separate function rather than implementing it on We could also remove v1beta1 now. Can't find any cloud providers supporting Kubernetes < 1.16 anymore. |
@kazk you able to have a look at this? |
Sketch for #569 Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
- while v1 is active; you cannot write to v2 and simultaneously maintain v2 schema - while v2 is active; you cannot write to v1 and simultaneously maintain v1 schema this means that you can end up: - not being able to from the v1 api if v2 is not backwards compat - not being able to read from v2 api if v1 is not forwards compat Signed-off-by: clux <[email protected]>
changing to &str Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Even with v1beta1 removed, I don't think the api is nicer with a static |
Implementation for #569. Follows official docs.
Docs touch on #865 because it's hard to recommend multi-versioning without it, but users can hack around it.
Tests add some dependencies use elsewhere in project (
assert_json_diff
from examples).The example is the most interesting, found out this with 2 versions:
this means that you can end up:
tried to clarify this as well as possible in the example and docs.