Replace runtime::controller::Context with Arc #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
nightkr
force-pushed
the
chore/burninate-controller-context
branch
from
deddf97 to
e70b340
Compare
nightkr
added
runtime
clux
added a commit
to kube-rs/controller-rs
that referenced
this pull request
May 13, 2022
Signed-off-by: clux <[email protected]>
|
Yeah, I like this a lot better. Tried it in controller-rs (kube-rs/controller-rs#29) and it simplifies things a lot not having to |
clux
approved these changes
May 13, 2022
kazk
approved these changes
May 13, 2022
clux
added a commit
to kube-rs/controller-rs
that referenced
this pull request
May 23, 2022
* Use kube-rs/kube#910 Signed-off-by: clux <[email protected]> * PoC Predicates for kube-rs/kube#52 Signed-off-by: clux <[email protected]> * remove predicate stuff Signed-off-by: clux <[email protected]> * undo crd update Signed-off-by: clux <[email protected]> * build from branch Signed-off-by: clux <[email protected]> * kube bump Signed-off-by: clux <[email protected]> * bump Signed-off-by: clux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
controller::Contextwas just a newtype aroundstd::sync::Arcthat was confusing, added no new features, had annoying name clashes (including withkube::config::Context) and had slightly worse ergonomics (had to useContext::get_ref()rather than there being aDerefimplementation).Solution
Replace it with using
std::sync::Arcdirectly.