Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadbalancerClass support #66

Closed

Conversation

lubronzhan
Copy link
Collaborator

@lubronzhan lubronzhan commented May 24, 2023

Fix #61

  • kube-vip-cloud-provider can allocate ip to service only set with kube-vip loadbalancerclass kube-vip.io/kube-vip-class, by passing KUBEVIP_ENABLE_LOADBALANCERCLASS env variable to kube-vip-cloud-provider
  • User can also set custom loadbalancerclass name through env variable KUBEVIP_CUSTOM_LOADBALANCERCLASS_NAME, User can set KUBEVIP_CUSTOM_LOADBALANCERCLASS_NAME without setting KUBEVIP_ENABLE_LOADBALANCERCLASS

Conditions

  1. If service has loadbalancerClass, kube-vip-cloud-provider is not configured with loadbalancerClass, kube-vip-cloud-provider will ignore the service
  2. If service doesn't have loadbalancerClass, kube-vip-cloud-provider is configured with loadbalancerClass, kube-vip-
    cloud-provider will ignore the service
  3. If service has loadbalancerClass, kube-vip-cloud-provider is configured with loadbalancerClass, kube-vip-
    cloud-provider will allocate ip for the service
  4. If service doesn't have loadbalancerClass, kube-vip-cloud-provider is not configured with loadbalancerClass, kube-vip-
    cloud-provider will allocate ip for the service

Signed-off-by: lubronzhan <[email protected]>
@lubronzhan lubronzhan force-pushed the topic/lubron/loadbalancerclass branch 2 times, most recently from d3aabfc to 4d31be6 Compare May 24, 2023 17:50
Signed-off-by: lubronzhan <[email protected]>
@lubronzhan lubronzhan force-pushed the topic/lubron/loadbalancerclass branch from 4d31be6 to 9108201 Compare May 24, 2023 17:51
Signed-off-by: lubronzhan <[email protected]>
@lubronzhan
Copy link
Collaborator Author

Close this since it's not ready

@lubronzhan lubronzhan closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support for loadBalancerClass
1 participant