controller check error #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
kind/cleanup
m1093782566
reviewed
May 29, 2019
m1093782566
reviewed
May 29, 2019
|
Squash commits please. |
subpathdev
force-pushed
the
dtControllerCheckError
branch
from
e2c1348 to
ee0633b
Compare
|
/retest |
|
/lgtm leave approve to @sids-b @edisonxiang |
|
I didn't understand why the build failed. (Here is a success travis build on the same changes: https://travis-ci.org/subpathdev/kubeedge ) |
|
/retest |
|
@subpathdev , you need to make changes in the UT's as this err return would not be there in the code and it will continue to execute |
|
The overall change looks good to me though |
m1093782566
reviewed
May 30, 2019
| @@ -330,6 +330,24 @@ func TestDTController_distributeMsg(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| //Sucess Case | |||
|
LGTM Overall. Can merge this PR once @m1093782566 review comments fixed |
|
Please squash the commits. |
* create test case distributeMsg chan no found * create test case distributeMsg sucessfull
subpathdev
force-pushed
the
dtControllerCheckError
branch
from
c4b1a00 to
336014d
Compare
|
/approve THANKS! |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In this line we can see, that the CommTo return nil or an error. https://github.com/kubeedge/kubeedge/blob/master/edge/pkg/devicetwin/dtcontext/dtcontext.go#L71
In this PR I take this error and create an error in function distributeMsg (
kubeedge/edge/pkg/devicetwin/dtcontroller.go
Line 116 in 98c2762
kubeedge/edge/pkg/devicetwin/dtcontroller.go
Line 79 in 98c2762
In my opinion we should check if an error occur or not when it is possible. This will also increase the possibility to debug the program.
Which issue(s) this PR fixes:
Special notes for your reviewer: