Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapper lint error #6090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wbc6080
Copy link
Collaborator

@wbc6080 wbc6080 commented Jan 16, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

Fix lint error in mapper-framework.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: wbc6080 <[email protected]>
@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2025
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@wbc6080
Copy link
Collaborator Author

wbc6080 commented Jan 17, 2025

cc @luomengY @WillardHu @fisherxu

@luomengY
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI cannot check lint error in mapper? Can we add lint check for mapper in CI?

@wbc6080
Copy link
Collaborator Author

wbc6080 commented Jan 17, 2025

CI cannot check lint error in mapper? Can we add lint check for mapper in CI?

We have previously added mapper checks to lint. https://github.com/kubeedge/kubeedge/blob/master/hack/lib/lint.sh#L81 The currently problem code is located in the _template directory of mapper-framework. This part is the mapper template and cannot be compiled and run normally, which should be the reason why lint cannot check it. Only after executing make generate to generate the mapper project can this part of the code run normally. I will see if there is a suitable solution later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants