Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update edge_core version to reflect the vendor k8s and kubeedge version #761

Merged
merged 1 commit into from
Jun 23, 2019
Merged

update edge_core version to reflect the vendor k8s and kubeedge version #761

merged 1 commit into from
Jun 23, 2019

Conversation

sids-b
Copy link
Member

@sids-b sids-b commented Jun 23, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Make the edge node version reflect the vendored k8s version and kubeedge version

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 23, 2019
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2019
rohitsardesai83
rohitsardesai83 reviewed Jun 23, 2019
View reviewed changes
Copy link
Collaborator

@rohitsardesai83 rohitsardesai83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2019
@rohitsardesai83
Copy link
Collaborator

/approve

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@rohitsardesai83 rohitsardesai83 removed the request for review from CindyXing June 23, 2019 17:38
rohitsardesai83
rohitsardesai83 approved these changes Jun 23, 2019
View reviewed changes
Copy link
Collaborator

@rohitsardesai83 rohitsardesai83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitsardesai83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot merged commit 1057fc1 into kubeedge:master Jun 23, 2019
@rohitsardesai83 rohitsardesai83 mentioned this pull request Jun 23, 2019
Merged
kubeedge-bot added a commit that referenced this pull request Jun 23, 2019
@kubeedge-bot
Merge pull request #767 from rohitsardesai83/automated-cherry-pick-of…
8c8df29 
…-#761-upstream-release-1.0

Automated cherry pick of #761: update edge_core version to reflect the vendor k8s and kubeedge version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitsardesai83 rohitsardesai83 rohitsardesai83 approved these changes

Assignees

@rohitsardesai83 rohitsardesai83

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sids-b @rohitsardesai83 @kubeedge-bot