Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm crd can not generete error #472

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

tangming1996
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix helm crd can not generete error
Which issue(s) this PR fixes:

Fixes #468

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2025
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@tangming1996 tangming1996 force-pushed the bugfix/crd-update-helm branch from 41a9838 to 40484e9 Compare February 20, 2025 10:35
@tangming1996 tangming1996 force-pushed the bugfix/crd-update-helm branch from 40484e9 to 11600c6 Compare February 21, 2025 02:04
@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025
@tangming1996
Copy link
Collaborator Author

This PR primarily fixes the issue where the CRD resources in the Helm chart are not updated.

The specific issue is that if the Sedna API changes but the CRD resources in the Helm chart are not updated, users will continue to use the old API when installing a new version using Helm.
@MooreZheng @hsj576

@hsj576
Copy link
Member

hsj576 commented Mar 3, 2025

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the routine meeting, this PR aims to make sure the updated Sedna API is used when using helm install.

@MooreZheng
Copy link
Collaborator

/lgtm

@MooreZheng
Copy link
Collaborator

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@MooreZheng MooreZheng requested review from MooreZheng and hsj576 and removed request for Poorunga March 3, 2025 10:50
@kubeedge-bot kubeedge-bot merged commit eaed7da into kubeedge:main Mar 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
4 participants