-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 1 | ||
path: ${{ env.GOPATH }}/src/github.com/kubeflow/common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not remember the default behavior here. Without specifying the ref, does it by default
- fetch HEAD for
pull_request
? - fetch master for
push
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch, tag or SHA to checkout. When checking out the repository that
triggered a workflow, this defaults to the reference or SHA for that event.
Otherwise, uses the default branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok yeah, as per docs:
- pull_request -> Last merge commit on the GITHUB_REF branch (master)
- push -> Commit pushed
@SumLare Thanks for taking this story. Can you help look at the comments? |
Thanks for the contribution. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#162
Looks like Coveralls api is under maintenance right now, hopefully ci turns green after they finish