Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Move ci from travis to github actions #164

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

SumLare
Copy link
Contributor

@SumLare SumLare commented Sep 19, 2021

#162

Looks like Coveralls api is under maintenance right now, hopefully ci turns green after they finish

@google-cla
Copy link

google-cla bot commented Sep 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SumLare
Copy link
Contributor Author

SumLare commented Sep 19, 2021

@googlebot I signed it!

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
- uses: actions/checkout@v2
with:
fetch-depth: 1
path: ${{ env.GOPATH }}/src/github.com/kubeflow/common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not remember the default behavior here. Without specifying the ref, does it by default

  1. fetch HEAD for pull_request?
  2. fetch master for push

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch, tag or SHA to checkout. When checking out the repository that
triggered a workflow, this defaults to the reference or SHA for that event.
Otherwise, uses the default branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok yeah, as per docs:

  1. pull_request -> Last merge commit on the GITHUB_REF branch (master)
  2. push -> Commit pushed

@Jeffwan
Copy link
Member

Jeffwan commented Sep 19, 2021

@SumLare Thanks for taking this story. Can you help look at the comments?

@Jeffwan
Copy link
Member

Jeffwan commented Sep 20, 2021

Thanks for the contribution.

/lgtm
/approve

@google-oss-robot google-oss-robot merged commit a86572b into kubeflow:master Sep 20, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants