Create a deployment to run the HP/Katib controller for the GitHub issue example #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue example. * Some of the code is copied over from https://github.com/kubeflow/katib/tree/master/examples/GKEDemo * I think it makes sense to centralize all the code in a single place. * Update the controller program (git-issue-summarize-demo.go) so that can specify the Docker image containing the training code. * Create a ksonnet deployment for running the controller on the cluster. * The HP tuning job isn't functional here's an incomplete list of issues * The training jobs launched fail because they don't have GCP credentials so they can't download the data. * We don't actually extract and report metrics back to Katib. Related to: kubeflow/katib#116
|
/assign @YujiOshima @gaocegege |
jlewi
added a commit
to jlewi/katib
that referenced
this pull request
Jun 30, 2018
* The GKEDemo is using the GitHub summarization example; I think we should put all of the code for that demo kubeflow/examples (see kubeflow/examples#161) * The main code is the Katib HP controller git-issue-summarize-demo.go * We don't need the manifests for deploying katib because we can deploy Katib using the Kubeflow ksonnet package. * The code in docker-image duplicates the code in kubeflow/examples so we shouldn't need it. Related to: kubeflow#116
k8s-ci-robot
pushed a commit
to kubeflow/katib
that referenced
this pull request
Jul 1, 2018
* The GKEDemo is using the GitHub summarization example; I think we should put all of the code for that demo kubeflow/examples (see kubeflow/examples#161) * The main code is the Katib HP controller git-issue-summarize-demo.go * We don't need the manifests for deploying katib because we can deploy Katib using the Kubeflow ksonnet package. * The code in docker-image duplicates the code in kubeflow/examples so we shouldn't need it. Related to: #116
|
/assign @ankushagarwal |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code is copied over from https://github.com/kubeflow/katib/tree/master/examples/GKEDemo
Update the controller program (git-issue-summarize-demo.go) so that can
specify the Docker image containing the training code.
Create a ksonnet deployment for running the controller on the cluster.
The HP tuning job isn't functional here's an incomplete list of issues
The training jobs launched fail because they don't have GCP credentials
so they can't download the data.
We don't actually extract and report metrics back to Katib.
Related to: kubeflow/katib#116
This change is