Skip to content

Commit

Permalink
Fix wrong suggestion service endpoint (#911)
Browse files Browse the repository at this point in the history
  • Loading branch information
hougangliu authored and k8s-ci-robot committed Nov 5, 2019
1 parent c18bab6 commit 02ccbff
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
suggestionsv1alpha3 "github.com/kubeflow/katib/pkg/apis/controller/suggestions/v1alpha3"
trialsv1alpha3 "github.com/kubeflow/katib/pkg/apis/controller/trials/v1alpha3"
suggestionapi "github.com/kubeflow/katib/pkg/apis/manager/v1alpha3"
"github.com/kubeflow/katib/pkg/controller.v1alpha3/consts"
"github.com/kubeflow/katib/pkg/controller.v1alpha3/util"
)

Expand Down Expand Up @@ -103,7 +102,7 @@ func (g *General) SyncAssignments(
// ValidateAlgorithmSettings validates if the algorithm specific configurations are valid.
func (g *General) ValidateAlgorithmSettings(instance *suggestionsv1alpha3.Suggestion, e *experimentsv1alpha3.Experiment) error {
logger := log.WithValues("Suggestion", types.NamespacedName{Name: instance.GetName(), Namespace: instance.GetNamespace()})
endpoint := fmt.Sprintf("%s:%d", instance.Name, consts.DefaultSuggestionPort)
endpoint := util.GetAlgorithmEndpoint(instance)
conn, err := grpc.Dial(endpoint, grpc.WithInsecure())
if err != nil {
return err
Expand Down

0 comments on commit 02ccbff

Please sign in to comment.