Refactored unit test that uses cmp.Diff

Signed-off-by: tariq-hasan <[email protected]>
kubeflow · Apr 7, 2024 · 4c6db3c · 4c6db3c
1 parent 59e489e
commit 4c6db3c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go b/pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient_test.go
@@ -577,10 +577,12 @@ func TestConvertTrialObservation(t *testing.T) {
 		},
 	}
 	for _, tc := range tcs {
-		actualObservation := convertTrialObservation(tc.strategies, tc.inObservation)
-		if diff := cmp.Diff(actualObservation, tc.expectedObservation); diff != "" {
-			t.Errorf("Case: %v failed. Diff (-want,+got):\n%s", tc.testDescription, diff)
-		}
+		t.Run(tc.testDescription, func(t *testing.T) {
+			actualObservation := convertTrialObservation(tc.strategies, tc.inObservation)
+			if diff := cmp.Diff(actualObservation, tc.expectedObservation); diff != "" {
+				t.Errorf("Unexpected observation (-want,+got):\n%s", diff)
+			}
+		})
 	}
 }