More container fields for SuggestionConfig

kubeflow · Nov 5, 2022 · c6f87bd · c6f87bd
1 parent 54b020b
commit c6f87bd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/pkg/controller.v1beta1/suggestion/composer/composer.go b/pkg/controller.v1beta1/suggestion/composer/composer.go
@@ -186,6 +186,11 @@ func (g *General) desiredContainers(s *suggestionsv1beta1.Suggestion,
 		Name:            consts.ContainerSuggestion,
 		Image:           suggestionConfigData.Image,
 		ImagePullPolicy: suggestionConfigData.ImagePullPolicy,
+		Command:         suggestionConfigData.Command,
+		Args:            suggestionConfigData.Args,
+		WorkingDir:      suggestionConfigData.WorkingDir,
+		EnvFrom:         suggestionConfigData.EnvFrom,
+		Env:             suggestionConfigData.Env,
 		Ports: []corev1.ContainerPort{
 			{
 				Name:          consts.DefaultSuggestionPortName,

diff --git a/pkg/util/v1beta1/katibconfig/config.go b/pkg/util/v1beta1/katibconfig/config.go
@@ -36,6 +36,11 @@ import (
 type SuggestionConfig struct {
 	Image                     string                           `json:"image"`
 	ImagePullPolicy           corev1.PullPolicy                `json:"imagePullPolicy,omitempty"`
+	Command                   []string                         `json:"command,omitempty"`
+	Args                      []string                         `json:"args,omitempty"`
+	WorkingDir                string                           `json:"workingDir,omitempty"`
+	EnvFrom                   []corev1.EnvFromSource           `json:"envFrom,omitempty"`
+	Env                       []corev1.EnvVar                  `json:"env,omitempty"`
 	Resource                  corev1.ResourceRequirements      `json:"resources,omitempty"`
 	ServiceAccountName        string                           `json:"serviceAccountName,omitempty"`
 	VolumeMountPath           string                           `json:"volumeMountPath,omitempty"`