-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace reflect.DeepEqual with cmp.Diff in tests #2268
Comments
/good-first-issue |
@tenzen-y: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tenzen-y I would like to take on this ticket. |
Sure, Feel free to assign this yourself with "/assign" comment. |
/assign |
Hi @tenzen-y Is this issue solved or I can work on it? |
@tariq-hasan Are you still working on this? |
I am working on it. I will open a new PR. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
/kind feature
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
To improve visibility, we should replace
reflect.DeepEqual
withcmp.Diff
in all test cases: https://github.com/kubeflow/katib/blob/master/docs/developer-guide.md#go-developmentHere is an example for using
cmp.Diff
:katib/pkg/apis/config/v1beta1/defaults_test.go
Lines 88 to 90 in 8df3c5c
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Love this feature? Give it a 👍 We prioritize the features with the most 👍
The text was updated successfully, but these errors were encountered: