Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chocolate mocmaes algorithm name in Suggestion #1097

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Mar 20, 2020

Fixes: #1094.

I tried to run mocmaes algorithm.
The run was successful for me.
I was using search space from this example: https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/grid-example.yaml.

/cc @gaocegege @terrykong


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from gaocegege March 20, 2020 22:37
@k8s-ci-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: terrykong.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #1094.

I tried to run mocmaes algorithm.
The run was successful for me.
I was using search space from this example: https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/grid-example.yaml.

/cc @gaocegege @terrykong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/retest

1 similar comment
@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit bad07f9 into kubeflow:master Mar 23, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich andreyvelich deleted the issue-1094-mocmaes-algorithm-name branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chocolate-MOCMAES has illegal name
3 participants