UI: Suggestion view from Experiment page #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Experiment dialog view to React Ace
Add style Fix GetAllNasJob Error
|
This change is |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sperlingxx
pushed a commit
to sperlingxx/katib
that referenced
this pull request
Jul 9, 2020
* Suggestion dialog view Change Experiment dialog view to React Ace * Update UI rbac Add style Fix GetAllNasJob Error * Fix style * Fix Prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1148.
I added Suggestion view to Experiment page. Also, I changed style of Experiment view to React Ace to be consistent between different forms.
When Suggestion is failed, user can see appropriate information of Suggestion dialog view and highlighted lines in JSON.
/assign @johnugeorge @gaocegege