Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus scraping and grafana support to charmed katib-controller operator #1839

Merged
merged 14 commits into from
Apr 14, 2022
Merged

Add prometheus scraping and grafana support to charmed katib-controller operator #1839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5afb811
Add prometheus scraping and grafana support to charmed operator
jardon Mar 28, 2022
cab6db4
Upgrade black version to 22.3.0 to fix issue with click dependency
jardon Mar 31, 2022
304b93f
fix: unpin `black`, fix formatting errors
ca-scribner Apr 4, 2022
ccb7ec0
fix: minor refactor of prometheus integration
ca-scribner Apr 4, 2022
02844cb
fix: apply operator linting checks only to source code
ca-scribner Apr 4, 2022
5d70409
chore: point katib-db to charm in charmhub
ca-scribner Apr 4, 2022
7b01657
fix: remove unneeded handling of prometheus relation event
ca-scribner Apr 4, 2022
d013ef9
feat: Add template dashboard and alert rules
ca-scribner Apr 11, 2022
643d9b8
fix: handle leader-elected events
ca-scribner Apr 11, 2022
33dce6d
fix: correctly template the sample grafana dashboard
ca-scribner Apr 11, 2022
70aa6fe
fix: remove placeholder grafana/prometheus files
ca-scribner Apr 12, 2022
dd7e91f
Merge pull request #2 from ca-scribner/monitoring
jardon Apr 12, 2022
f9400a1
fix: bump wait time to avoid flaky test failure
ca-scribner Apr 13, 2022
f27be59
Merge pull request #3 from ca-scribner/patch-2
jardon Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test-charmed-katib.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ jobs:
set -eux
sudo apt update
sudo apt install python3-setuptools
sudo pip3 install black==20.8b1 flake8
sudo pip3 install black flake8

- name: Check black
run: black --check operators
run: black --check operators/*/src

- name: Check flake8
run: cd operators && flake8
run: cd operators && flake8 ./katib*/src

build:
name: Test
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
sg microk8s -c 'juju bootstrap microk8s uk8s'
juju add-model kubeflow
juju bundle deploy --build --destructive-mode --serial
juju wait -wvt 300
juju wait -wvt 600

- name: Test Katib
run: kubectl apply -f examples/v1beta1/hp-tuning/random.yaml
Expand Down
2 changes: 1 addition & 1 deletion operators/bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
bundle: kubernetes
applications:
katib-controller: { charm: katib-controller, scale: 1 }
katib-db: { charm: cs:~charmed-osm/mariadb-k8s, scale: 1, options: { database: katib } }
katib-db: { charm: charmed-osm-mariadb-k8s, scale: 1, options: { database: katib } }
katib-db-manager: { charm: katib-db-manager, scale: 1 }
katib-ui: { charm: katib-ui, scale: 1 }
relations:
Expand Down
Loading