Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC] Compatibility Changes in Trial Controller #2394

Merged
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4410c1b
chore: add condition branch in requeue logic.
Electronic-Waste Jul 23, 2024
8a92977
chore: add ReportObservationLog in katib_manager_util.go.
Electronic-Waste Jul 23, 2024
4fb810c
chore: add ReportTrialUnavailableMetrics func.
Electronic-Waste Jul 23, 2024
712af68
chore: insert unavailable value into Katib DB.
Electronic-Waste Jul 23, 2024
76e3c95
fix: fix lint error.
Electronic-Waste Jul 23, 2024
7f6271b
fix: add nil condition judgement.
Electronic-Waste Jul 26, 2024
46a5afd
fix: add nil condition judgement in trial_controller_util.go
Electronic-Waste Jul 26, 2024
59e98a3
chore(trial): delete nil check of MC kind in the Trial controller.
Electronic-Waste Aug 2, 2024
bc9106e
chore(trial): init MC in newFakeTrialBatchJob to avoid nil condition …
Electronic-Waste Aug 2, 2024
a8c9d90
fix(trial): fix lint error.
Electronic-Waste Aug 2, 2024
4d1d010
fix(trial): fix lint error in controller.
Electronic-Waste Aug 2, 2024
45e4446
test(trial): add integration test for Push MC.
Electronic-Waste Aug 2, 2024
e0bd76a
chore(trial): retry reconcilation when reporting unavailable metrics …
Electronic-Waste Aug 25, 2024
7971594
test(trial): fix EXPECT order.
Electronic-Waste Aug 25, 2024
2b6b4c1
test(trial): fix typo error.
Electronic-Waste Aug 25, 2024
b2872ec
chore(trial): add errReportMetricsFailed.
Electronic-Waste Aug 26, 2024
17d5610
Update pkg/controller.v1beta1/trial/trial_controller.go
Electronic-Waste Aug 27, 2024
11d71af
Update pkg/controller.v1beta1/trial/trial_controller_util.go
Electronic-Waste Aug 28, 2024
303938b
Update pkg/controller.v1beta1/trial/trial_controller.go
Electronic-Waste Aug 28, 2024
541ec26
fix(trial): rename errors pkg.
Electronic-Waste Aug 28, 2024
2fe8c33
test(trial): update the order of UT.
Electronic-Waste Sep 1, 2024
8495589
test(trial): use different names for UTs.
Electronic-Waste Sep 3, 2024
af40d1f
test(trial): separate Push MC UTs with original UTs.
Electronic-Waste Sep 9, 2024
60214c8
test(trial): fix line error with gofmt.
Electronic-Waste Sep 9, 2024
008a574
test(trial): reserve one UT for Push MC.
Electronic-Waste Sep 9, 2024
ffe6089
test(trial): fix typo error.
Electronic-Waste Sep 10, 2024
ddd2cb3
test(trial): make some tiny changes.
Electronic-Waste Sep 11, 2024
6a7a528
fix(trial): move cancel func to t.Cleanup.
Electronic-Waste Sep 19, 2024
7cb4e3e
fix(trial): use the propagated gomega instance to improve debuggability.
Electronic-Waste Sep 19, 2024
9604ed4
fix(trial): use gofmt to reformat code.
Electronic-Waste Sep 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(trial): move cancel func to t.Cleanup.
Signed-off-by: Electronic-Waste <[email protected]>
Electronic-Waste committed Sep 19, 2024

Unverified

This user has not yet uploaded their public signing key.
commit 6a7a528e15da31cd1f675927a0596eff5ef1023f
4 changes: 1 addition & 3 deletions pkg/controller.v1beta1/trial/trial_controller_test.go
Original file line number Diff line number Diff line change
@@ -170,6 +170,7 @@ func TestReconcileBatchJob(t *testing.T) {

// Start test manager
mgrCtx, cancel := context.WithCancel(context.TODO())
t.Cleanup(cancel)
go func() {
g.Expect(mgr.Start(mgrCtx)).NotTo(gomega.HaveOccurred())
}()
@@ -364,9 +365,6 @@ func TestReconcileBatchJob(t *testing.T) {
g := gomega.NewGomegaWithT(t)
g.Expect(r.updateStatus(&trialsv1beta1.Trial{})).To(gomega.HaveOccurred())
})

// Stop the test manager
cancel()
}

func TestGetObjectiveMetricValue(t *testing.T) {