-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Refactor inject_webhook_test.go
according to the Developer Guide
#2401
[Test] Refactor inject_webhook_test.go
according to the Developer Guide
#2401
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
inject_webhook.go
according to the Developer Guideinject_webhook_test.go
according to the Developer Guide
Signed-off-by: Electronic-Waste <[email protected]>
I've added the missing UT which was deleted by accident now. PTAL👀 @tenzen-y if you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I refactored
/pkg/webhook/v1beta1/pod/inject_webhook_test.go
with rule described in Developer Guide:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2388
Checklist: