Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove remaining MXNet dependency. #2456

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ Katib supports
Katib is the project which is agnostic to machine learning (ML) frameworks.
It can tune hyperparameters of applications written in any language of the
users’ choice and natively supports many ML frameworks, such as
[TensorFlow](https://www.tensorflow.org/), [Apache MXNet](https://mxnet.apache.org/),
[PyTorch](https://pytorch.org/), [XGBoost](https://xgboost.readthedocs.io/en/latest/), and others.
[TensorFlow](https://www.tensorflow.org/), [PyTorch](https://pytorch.org/), [XGBoost](https://xgboost.readthedocs.io/en/latest/), and others.

Katib can perform training jobs using any Kubernetes
[Custom Resources](https://www.kubeflow.org/docs/components/katib/trial-template/)
Expand Down
11 changes: 0 additions & 11 deletions docs/images-location.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,17 +271,6 @@ The following table shows images for training containers which are used in the
<a href="https://github.com/kubeflow/katib/blob/master/examples/v1beta1/trial-images/tf-mnist-with-summaries/Dockerfile">Dockerfile</a>
</td>
</tr>
<tr align="center">
<td>
<code>docker.io/bytepsimage/mxnet</code>
</td>
<td>
Distributed BytePS example for MXJob
</td>
<td>
<a href="https://github.com/bytedance/byteps/blob/v0.2.5/docker/Dockerfile">Dockerfile</a>
</td>
</tr>
<tr align="center">
<td>
<code>docker.io/kubeflowkatib/xgboost-lightgbm</code>
Expand Down
2 changes: 0 additions & 2 deletions examples/v1beta1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ Check the following examples for the various distributed operators:

- [PyTorchJob MNIST](./kubeflow-training-operator/pytorchjob-mnist.yaml)

- [MXJob BytePS](./kubeflow-training-operator/mxjob-byteps.yaml)

- [XGBoostJob LightGBM](./kubeflow-training-operator/xgboostjob-lightgbm.yaml)

- [MPIJob Horovod](./kubeflow-training-operator/mpijob-horovod.yaml)
Expand Down
2 changes: 1 addition & 1 deletion examples/v1beta1/kubeflow-pipelines/early-stopping.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"In this notebook you will:\n",
"- Create Katib Experiment using random algorithm.\n",
"- Use median stopping rule as an early stopping algorithm.\n",
"- Use Kubernetes Job with mxnet mnist training container as a Trial template.\n",
"- Use Kubernetes Job with pytorch mnist training container as a Trial template.\n",
"- Create Pipeline to get the optimal hyperparameters.\n",
"\n",
"Reference documentation:\n",
Expand Down
86 changes: 0 additions & 86 deletions examples/v1beta1/kubeflow-training-operator/mxjob-byteps.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions hack/gen-python-sdk/post_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ def _rewrite_helper(input_file, output_file, rewrite_rules):
lines.append(
"from kubeflow.katib.constants.constants import BASE_IMAGE_PYTORCH\n"
)
lines.append(
"from kubeflow.katib.constants.constants import BASE_IMAGE_MXNET\n"
)

# Add Kubernetes models to proper deserialization of Katib models.
if output_file == "sdk/python/v1beta1/kubeflow/katib/models/__init__.py":
Expand Down
1 change: 0 additions & 1 deletion manifests/v1beta1/components/controller/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ rules:
- pytorchjobs
- mpijobs
- xgboostjobs
- mxjobs
verbs:
- "get"
- "list"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
runtime:
metricsCollectors:
- kind: StdOut
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
runtime:
metricsCollectors:
- kind: StdOut
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
runtime:
metricsCollectors:
- kind: StdOut
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
runtime:
metricsCollectors:
- kind: StdOut
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
runtime:
metricsCollectors:
- kind: StdOut
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
runtime:
metricsCollectors:
- kind: StdOut
Expand Down
1 change: 0 additions & 1 deletion pkg/apis/controller/experiments/v1beta1/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ var (
"TFJob": true,
"PyTorchJob": true,
"XGBoostJob": true,
"MXJob": true,
"MPIJob": true,
}
)
2 changes: 0 additions & 2 deletions pkg/util/v1beta1/katibconfig/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,6 @@ init:
- PyTorchJob.v1.kubeflow.org
- MPIJob.v1.kubeflow.org
- XGBoostJob.v1.kubeflow.org
- MXJob.v1.kubeflow.org
webhookPort: 18443
enableLeaderElection: true
leaderElectionID: xyz0123
Expand Down Expand Up @@ -456,7 +455,6 @@ runtime:
"PyTorchJob.v1.kubeflow.org",
"MPIJob.v1.kubeflow.org",
"XGBoostJob.v1.kubeflow.org",
"MXJob.v1.kubeflow.org",
},
WebhookPort: &customizedWebhookPort,
EnableLeaderElection: true,
Expand Down
1 change: 0 additions & 1 deletion sdk/python/v1beta1/kubeflow/katib/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,3 @@
from kubeflow.katib.constants.constants import BASE_IMAGE_TENSORFLOW
from kubeflow.katib.constants.constants import BASE_IMAGE_TENSORFLOW_GPU
from kubeflow.katib.constants.constants import BASE_IMAGE_PYTORCH
from kubeflow.katib.constants.constants import BASE_IMAGE_MXNET
1 change: 0 additions & 1 deletion sdk/python/v1beta1/kubeflow/katib/constants/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
BASE_IMAGE_TENSORFLOW = "docker.io/tensorflow/tensorflow:2.13.0"
BASE_IMAGE_TENSORFLOW_GPU = "docker.io/tensorflow/tensorflow:2.13.0-gpu"
BASE_IMAGE_PYTORCH = "docker.io/pytorch/pytorch:2.2.1-cuda12.1-cudnn8-runtime"
BASE_IMAGE_MXNET = "docker.io/mxnet/python:1.9.1_native_py3"

DEFAULT_DB_MANAGER_ADDRESS = "katib-db-manager.kubeflow:6789"

Expand Down