chore: supporting the listen-address parameter on db-manager

[caiofralmeida]

What this PR does / why we need it: I would like to be able to pass a different listen-address to handle other ports or even ipv6.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

• Docs included if any changes are user facing

[tenzen-y]

Thank you for making the address customizable.
This looks great to me.
/approve
/rerun-all

@kubeflow/wg-automl-leads How about this improvement?

[tenzen-y]

/rerun-all

[Electronic-Waste]

/lgtm

[Electronic-Waste]

/rerun-all

[Electronic-Waste]

/rerun-all

[Electronic-Waste]

/rerun-all

[Electronic-Waste]

/rerun-all

[andreyvelich]

Thank you for this contribution @caiofralmeida 🎉
@kubeflow/wg-automl-leads @caiofralmeida @Electronic-Waste @helenxie-bit Don't we want to use env variable to configure all settings for Katib DB Manager for now ?
Ideally, we should migrate to the Katib Config, but it could be done in the future.

The problem is that we have a few settings for Katib DB manager that need to configured via envs: https://www.kubeflow.org/docs/components/katib/user-guides/env-variables/#katib-db-manager

[caiofralmeida]

@andreyvelich thanks for the heads up. I can implement the listen-address configuration as an environment variable as well (in another PR) what do you think?

We just need to define which of the settings should take precedence.

[andreyvelich]

I would suggest that we migrate all Katib DB manager args to the envs as part of this PR:
CONNECT_TIMEOUT and LISTEN_ADDRESS
What do you think @caiofralmeida ?

[caiofralmeida]

@andreyvelich I agree with refactoring ARGs to environment variables, but I think that making this change in this PR will generate a braking change. I would feel more comfortable if we already had a way to override the listen address (through args) remove an impediment on our side and implement the PR by refactoring all args to environment variables, already doing the necessary tests, and declaring that ARGs will no longer be supported.

[andreyvelich]

Actually, it is a great point @caiofralmeida, I agree with you!
Ideally, we should migrate Katib DB manager settings to the Katib config all together, but we can do it later.
https://www.kubeflow.org/docs/components/katib/user-guides/katib-config/
If you could create tracking issue for it, that would be great!

[andreyvelich]

/rerun-all

[caiofralmeida]

Actually, it is a great point @caiofralmeida, I agree with you! Ideally, we should migrate Katib DB manager settings to the Katib config all together, but we can do it later. https://www.kubeflow.org/docs/components/katib/user-guides/katib-config/ If you could create tracking issue for it, that would be great!

Nice, I'm going to create a tracking issue right now. Thanks!

[andreyvelich]

@caiofralmeida Please can you re-push your commit to trigger GitHub actions ?
Since the action was triggered more than 1 month ago, GitHub doesn't allow me to trigger them.

[caiofralmeida]

@caiofralmeida Please can you re-push your commit to trigger GitHub actions ? Since the action was triggered more than 1 month ago, GitHub doesn't allow me to trigger them.

For sure, done @andreyvelich :)

[andreyvelich]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andreyvelich,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[caiofralmeida]

@andreyvelich I've created the issue. I have not found any template that fits the intention of the issue.