-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX deprecation warnings in kustomize 5 #2511
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Pedro Viana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manifests/v1beta1/installs/katib-with-kubeflow/kustomization.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @juliusvonkohout!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juliusvonkohout Can you sign your commit ? |
I first need to verify that the output stays the same when i run kustomize |
this is what i have to check |
@tarekabouzeid can you follow up here? |
shall i follow up here? |
That would be great @mahdikhashan! |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # kubeflow/manifests#2985
@andreyvelich @tenzen-y i just copied over the commit for now