Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX deprecation warnings in kustomize 5 #2511

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juliusvonkohout
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # kubeflow/manifests#2985

@andreyvelich @tenzen-y i just copied over the commit for now

Signed-off-by: Pedro Viana <[email protected]>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @juliusvonkohout!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

@juliusvonkohout Can you sign your commit ?

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 10, 2025

@juliusvonkohout Can you sign your commit ?

I first need to verify that the output stays the same when i run kustomize
/hold

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 10, 2025

$ diff -u old.yaml new.yaml
--- old.yaml    2025-02-10 18:50:39.299136200 +0100
+++ new.yaml    2025-02-10 18:50:19.568703200 +0100
@@ -913,7 +913,7 @@
 kind: MutatingWebhookConfiguration
 metadata:
   annotations:
-    cert-manager.io/inject-ca-from: kubeflow/katib-webhook-cert
+    cert-manager.io/inject-ca-from: KATIB_NAMESPACE_PLACEHOLDER/katib-webhook-cert
   name: katib.kubeflow.org
 webhooks:
 - admissionReviewVersions:
@@ -964,7 +964,7 @@
 kind: ValidatingWebhookConfiguration
 metadata:
   annotations:
-    cert-manager.io/inject-ca-from: kubeflow/katib-webhook-cert
+    cert-manager.io/inject-ca-from: KATIB_NAMESPACE_PLACEHOLDER/katib-webhook-cert
   name: katib.kubeflow.org
 webhooks:
 - admissionReviewVersions:

this is what i have to check

@juliusvonkohout
Copy link
Member Author

@tarekabouzeid can you follow up here?

@mahdikhashan
Copy link
Contributor

@tarekabouzeid can you follow up here?

shall i follow up here?

@andreyvelich
Copy link
Member

That would be great @mahdikhashan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants