Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete obsolete data in db #315

Merged
merged 3 commits into from
Jan 7, 2019
Merged

delete obsolete data in db #315

merged 3 commits into from
Jan 7, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Jan 4, 2019 •
edited by jlewi
Loading

Fixes: #311

This change is Reviewable

@hougangliu
Copy link
Member Author

/assign @richardsliu @YujiOshima

@YujiOshima
Copy link
Contributor

Thanks! A comment. When we delete a study, related resources( trials, workers ) should be also deleted.

@hougangliu
Copy link
Member Author

Thanks! A comment. When we delete a study, related resources( trials, workers ) should be also deleted.

yes, all other resources will be deleted in db owning to FOREIGN KEY(study_id) REFERENCES studies(id) ON DELETE CASCADE-like

@YujiOshima
Copy link
Contributor

Good. Then please add a test for delete study to https://github.com/kubeflow/katib/blob/master/test/e2e/test-client.go

@hougangliu
Copy link
Member Author

Good. Then please add a test for delete study to https://github.com/kubeflow/katib/blob/master/test/e2e/test-client.go

OK thanks

YujiOshima
YujiOshima reviewed Jan 6, 2019
View reviewed changes
test/e2e/test-client.go
if _, err := c.DeleteStudy(ctx, deleteStudyreq); err != nil {
log.Fatalf("DeleteStudy error %v", err)
}
log.Printf("Study %s is deleted", studyID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check resources (study, trial, worker) are deleted by GetStudy or GetWorkers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done

@YujiOshima
Copy link
Contributor

@hougangliu Thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f78a108 into kubeflow:master Jan 7, 2019
@hougangliu hougangliu deleted the finalizers branch January 14, 2019 01:44
@johnugeorge johnugeorge mentioned this pull request Jan 16, 2019
Closed
@hougangliu hougangliu mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YujiOshima YujiOshima YujiOshima left review comments

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

@texasmichelle texasmichelle Awaiting requested review from texasmichelle

Assignees

@YujiOshima YujiOshima

@richardsliu richardsliu

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hougangliu @YujiOshima @k8s-ci-robot @richardsliu