-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update REAME example links for v1alpha1 #452
Changes from all commits
0282b53
1e11069
c19ea4e
7ed905d
3bb70db
c21969c
8474e3c
e546268
1104560
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,7 +61,7 @@ A Suggestion is an algorithm to construct a parameter set. Currently Katib suppo | |
## Components in Katib | ||
|
||
Katib consists of several components as shown below. Each component is running on k8s as a deployment. | ||
Each component communicates with others via GRPC and the API is defined at `pkg/api/api.proto`. | ||
Each component communicates with others via GRPC and the API is defined at `pkg/api/v1alpha1/api.proto`. | ||
|
||
- vizier: main components. | ||
- vizier-core : API server of vizier. | ||
|
@@ -78,19 +78,19 @@ Each component communicates with others via GRPC and the API is defined at `pkg/ | |
|
||
## Getting Started | ||
|
||
Please see [README.md](./examples/README.md) for more details. | ||
Please see [README.md](./examples/v1alpha1/README.md) for more details. | ||
|
||
## Web UI | ||
|
||
Katib provides a Web UI. | ||
You can visualize general trend of Hyper parameter space and each training history. You can use | ||
[random-example](https://github.com/kubeflow/katib/blob/master/examples/random-example.yaml) or | ||
[other examples](https://github.com/kubeflow/katib/blob/master/examples) to generate a similar UI. | ||
[random-example](https://github.com/kubeflow/katib/blob/master/examples/v1alpha1/random-example.yaml) or | ||
[other examples](https://github.com/kubeflow/katib/blob/master/examples/v1alpha1) to generate a similar UI. | ||
![katibui](https://user-images.githubusercontent.com/10014831/48778081-a4388b80-ed17-11e8-938b-fc59a5d2e574.gif) | ||
|
||
## API Documentation | ||
|
||
Please refer to [api.md](./pkg/api/gen-doc/api.md). | ||
Please refer to [api.md](./pkg/api/v1alpha1/gen-doc/api.md). | ||
|
||
## Quickstart to run tfjob and pytorch operator jobs in Katib | ||
|
||
|
@@ -158,7 +158,7 @@ spec: | |
Create this pv after deploying Katib package | ||
|
||
``` | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/manifests/pv/pv.yaml | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/manifests/v1alpha1/pv/pv.yaml | ||
``` | ||
|
||
### Running examples | ||
|
@@ -189,21 +189,21 @@ spec: | |
If you are not using GKE and you don't have StorageClass for dynamic volume provisioning at your cluster, you have to create pvc and pv | ||
|
||
``` | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/tfevent-volume/tfevent-pvc.yaml | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/v1alpha1/tfevent-volume/tfevent-pvc.yaml | ||
|
||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/tfevent-volume/tfevent-pv.yaml | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/v1alpha1/tfevent-volume/tfevent-pv.yaml | ||
``` | ||
|
||
This is example for tfjob operator | ||
|
||
``` | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/tfjob-example.yaml | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/v1alpha1/tfjob-example.yaml | ||
``` | ||
|
||
This is example for pytorch operator | ||
|
||
``` | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/pytorchjob-example.yaml | ||
kubectl create -f https://raw.githubusercontent.com/kubeflow/katib/master/examples/v1alpha1/pytorchjob-example.yaml | ||
``` | ||
|
||
You can check status of StudyJob | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @alexandraj777 Thank you for your PR! |
||
|
@@ -359,7 +359,7 @@ ks delete ${KF_ENV} -c tf-job-operator | |
If you create pv for Katib, delete it | ||
|
||
``` | ||
kubectl delete -f https://raw.githubusercontent.com/kubeflow/katib/master/manifests/pv/pv.yaml | ||
kubectl delete -f https://raw.githubusercontent.com/kubeflow/katib/master/manifests/v1alpha1/pv/pv.yaml | ||
``` | ||
|
||
If you deploy Ambassador, delete it | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,12 +17,12 @@ dep ensure --vendor-only | |
You can build all images from source. | ||
|
||
```bash | ||
./scripts/build.sh | ||
./scripts/v1alpha1/build.sh | ||
``` | ||
|
||
## Implement new suggestion algorithm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think, we should also change path here: https://github.com/kubeflow/katib/pull/452/files#diff-ba23e0f18c79cb873ac5375367524cfaL20. |
||
|
||
Suggestion API is defined as GRPC service at `pkg/api/api.proto`. Source code is [here](https://github.com/kubeflow/katib/blob/master/pkg/api/api.proto). You can attach new algorithm easily. | ||
Suggestion API is defined as GRPC service at `pkg/api/v1alpha1/api.proto`. Source code is [here](https://github.com/kubeflow/katib/blob/master/pkg/api/v1alpha1/api.proto). You can attach new algorithm easily. | ||
|
||
- implement suggestion API | ||
- make k8s service named vizier-suggestion-{ algorithm-name } and expose port 6789 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
please also update linke of line 93, too.
In fact, links in https://github.com/kubeflow/katib/blob/master/docs/developer-guide.md and https://github.com/kubeflow/katib/blob/master/docs/rest-api.md need be updated, too