Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: support ParallelFor params which was defined in input/out #70

Closed
fenglixa opened this issue Mar 27, 2020 · 8 comments
Closed

Comments

@fenglixa
Copy link
Member

fenglixa commented Mar 27, 2020

If loop parameters are static, then we can parallel instance several taskrun with different parameter to workaround it.
But if the loop parameters are from the input/output parameter of pipeline/tasks, how it works for tekton pipeline?
e.g: https://github.com/kubeflow/pipelines/blob/master/samples/core/loop_parameter/loop_parameter.py

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@fenglixa fenglixa changed the title Does anyone know how to support/workaround ParallelFor params which was defined in input/out question: support ParallelFor params which was defined in input/out Mar 27, 2020
@fenglixa fenglixa changed the title question: support ParallelFor params which was defined in input/out Question: support ParallelFor params which was defined in input/out Mar 27, 2020
@fenglixa
Copy link
Member Author

@afrittoli @animeshsingh @vincent-pli @ckadner @Tomcli could you help?

@fenglixa
Copy link
Member Author

/kind question

@fenglixa
Copy link
Member Author

fenglixa commented Mar 31, 2020

Since Tekton doesn't have loop/recursion support, PR #67 will workaround the static parameters by flatten the loop with parallel taskruns.
But if it's dynamic params (e.g: input/output), seems we still need Tekton have this feature to address it.

@animeshsingh
Copy link
Collaborator

I belive we need inputs from @afrittoli @vincent-pli for this. Is there a view of how any pipelines currently are using dynamic links?

@afrittoli
Copy link
Contributor

We started looking at this kind of feature on Tekton side. Until we implement it I don't think there's a way to support the dynamic case.
We could perhaps have a single running over the params in a loop. It would not be parallel but it might work.

@stale
Copy link

stale bot commented Jan 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jun 2, 2021
gmfrasca pushed a commit to gmfrasca/data-science-pipelines-tekton that referenced this issue May 16, 2023
Rename Visualization Server overlay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants