Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dsl.ResourceOp #89

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Add support for dsl.ResourceOp #89

merged 1 commit into from
Apr 11, 2020

Conversation

fenglixa
Copy link
Member

@fenglixa fenglixa commented Apr 9, 2020

Which issue is resolved by this Pull Request:
Resolves #49

Description of your changes:

Based on kubectl-wrapper, we have following parameters in Tekton task right now, which are used for supporting Tekton resourceOps:

  • action: -- the action to perform to the resource
  • merge_strategy: -- the strategy used to merge a patch, defaults to "strategic"
  • success_condition: a label selector expression which describes the success condition
  • failure_condition: a label selector expression which describes the failure condition
  • manifest: the kubernetes manifest
  • output: An express to retrieval data from resource, all the output will be writen to tekton/result/output file.
  • set-ownerreference: Enable set owner reference for created resource, just leave interfaces there.

@vincent-pli , I think the code of kubectl-wrapper should be committed to kfp-tekton as well, to support more features in future, or any bug fixes.

@kubeflow-bot
Copy link

This change is Reviewable

@fenglixa
Copy link
Member Author

fenglixa commented Apr 9, 2020

/cc @animeshsingh

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @fenglixa, overall the compiler side looks very good. I will also take a look at the actual task and give some comments over there.

sdk/python/tests/compiler/compiler_tests.py Show resolved Hide resolved
sdk/python/tests/test_kfp_samples_report.txt Outdated Show resolved Hide resolved
sdk/python/kfp_tekton/compiler/compiler.py Outdated Show resolved Hide resolved
@Tomcli
Copy link
Member

Tomcli commented Apr 9, 2020

We probably need to have some instructions for adding certain rbac permission to this pipeline. I will open an issue and do it in a different PR.

Copy link
Collaborator

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fenglixa - great job!

I think the code of kubectl-wrapper should be committed to kfp-tekton as well, to support more features in future, or any bug fixes.

Isn't the wrapper going in Tekton repo?

@fenglixa
Copy link
Member Author

Thanks @Tomcli , I addressed you comments, please help review whether it's OK for you now.

@fenglixa
Copy link
Member Author

fenglixa commented Apr 10, 2020

Isn't the wrapper going in Tekton repo?

I discussed it with @vincent-pli before. It's better the wrapper could be going to Tekton repo, but seems it could be only going as Tekton catalog.
Personaly, we should find a location in kfp-tekton, to let the wrapper code there, convenient for us to maintain and add new features, how do you think? @animeshsingh .

@fenglixa fenglixa requested a review from Tomcli April 10, 2020 01:49
@Tomcli
Copy link
Member

Tomcli commented Apr 10, 2020

Thanks @fenglixa, it works well with the basic resourceOp example. However, the output only takes one argument where volumeOp and volumeSnapShotOp is expecting 3. Probably we need to enhance the output argument to output a list of results instead of a single output file. It's better to enhance the wrapper for that feature.

Although I do love to merge what we have now, so we can start work on the new features for volumeOp and volumeSnapShotOp in parallel.

/lgtm

@Tomcli
Copy link
Member

Tomcli commented Apr 10, 2020

@fenglixa So after some discussion with Animesh, we probably should push the warpper code to tektoncd/catalog because kfp-tekton shouldn't maintain any custom Tekton image. Also this way we can get more feedbacks from the tekton community. What do you think?

@fenglixa
Copy link
Member Author

So after some discussion with Animesh, we probably should push the warpper code to tektoncd/catalog because kfp-tekton shouldn't maintain any custom Tekton image. Also this way we can get more feedbacks from the tekton community. What do you think?

It's OK to me. Thanks.

@animeshsingh
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ebe05e3 into kubeflow:master Apr 11, 2020
@fenglixa fenglixa deleted the resourceops branch April 13, 2020 02:45
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines-tekton May 16, 2023
gmfrasca pushed a commit to gmfrasca/data-science-pipelines-tekton that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dsl.ResourceOp
5 participants