-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dsl.ResourceOp #89
Conversation
/cc @animeshsingh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @fenglixa, overall the compiler side looks very good. I will also take a look at the actual task and give some comments over there.
We probably need to have some instructions for adding certain rbac permission to this pipeline. I will open an issue and do it in a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fenglixa - great job!
I think the code of kubectl-wrapper should be committed to kfp-tekton as well, to support more features in future, or any bug fixes.
Isn't the wrapper going in Tekton repo?
Thanks @Tomcli , I addressed you comments, please help review whether it's OK for you now. |
I discussed it with @vincent-pli before. It's better the wrapper could be going to Tekton repo, but seems it could be only going as Tekton catalog. |
Thanks @fenglixa, it works well with the basic resourceOp example. However, the Although I do love to merge what we have now, so we can start work on the new features for volumeOp and volumeSnapShotOp in parallel. /lgtm |
@fenglixa So after some discussion with Animesh, we probably should push the warpper code to tektoncd/catalog because kfp-tekton shouldn't maintain any custom Tekton image. Also this way we can get more feedbacks from the tekton community. What do you think? |
It's OK to me. Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Clarify readme.
Rebase kfp-tekton v1.5.1
Which issue is resolved by this Pull Request:
Resolves #49
Description of your changes:
Based on kubectl-wrapper, we have following parameters in Tekton task right now, which are used for supporting Tekton resourceOps:
output
will be writen totekton/result/output
file.@vincent-pli , I think the code of kubectl-wrapper should be committed to kfp-tekton as well, to support more features in future, or any bug fixes.