Skip to content

Commit

Permalink
Removing dependencies on oidc-authservice
Browse files Browse the repository at this point in the history
  • Loading branch information
axel7083 committed Jul 25, 2023
1 parent 47f1d91 commit 681709e
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 132 deletions.
20 changes: 3 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,26 +179,12 @@ kustomize build common/dex/overlays/istio | kubectl apply -f -

#### Authservice

The oauth service is responsible for ensuring the requests of users are

#### Authservice

The Authservice is responsible for ensuring requests are authorized. Otherwise redirecting them to the provider (Here Dex is used as OIDC Provider). It is also responsible for adding the `kubeflow-userid` to the upstream request. You can find the sequence diagram for an Authentication Flow [here](https://github.com/arrikto/oidc-authservice/blob/master/docs/media/oidc_authservice_sequence_diagram.svg).

They are two available options the *OIDC AuthService* or the *OAuth2-proxy*. **You should not apply both.**

##### oidc-authservice

This is the default solution provided for kubeflow. The [OIDC AuthService](https://github.com/arrikto/oidc-authservice) extends your Istio Ingress-Gateway capabilities, to be able to function as an OIDC client:

```sh
kustomize build common/auth-proxy/overlays/oidc-authservice | kubectl apply -f -
```

##### OAuth2-proxy
The Authservice is responsible for ensuring requests are authorized. Otherwise redirecting them to the provider (Here Dex is used as OIDC Provider). It is also responsible for adding the `kubeflow-userid` to the upstream request.

The [OAuth2-proxy](https://github.com/oauth2-proxy/oauth2-proxy) will extends the istio Ingress-Gateway in the same way the *OIDC AuthService* is doing but offer more flexibility for handling requests. See the [documentation](https://oauth2-proxy.github.io/oauth2-proxy/docs/configuration/overview).

Install oauth2-proxy

```sh
kustomize build common/auth-proxy/overlays/oauth-proxy | kubectl apply -f -
```
Expand Down

This file was deleted.

This file was deleted.

24 changes: 0 additions & 24 deletions common/auth-proxy/overlays/oidc-authservice/kustomization.yaml

This file was deleted.

11 changes: 0 additions & 11 deletions common/auth-proxy/overlays/oidc-authservice/params.env

This file was deleted.

10 changes: 0 additions & 10 deletions common/auth-proxy/overlays/oidc-authservice/pvc.yaml

This file was deleted.

43 changes: 0 additions & 43 deletions common/auth-proxy/overlays/oidc-authservice/statefulset.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions example/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ resources:
- ../common/istio-1-16/istio-crds/base
- ../common/istio-1-16/istio-namespace/base
- ../common/istio-1-16/istio-install/base
# OIDC Authservice
- ../common/auth-proxy/overlays/oidc-authservice
# oauth
- ../common/auth-proxy/overlays/oauth2-proxy
# Dex
- ../common/dex/overlays/istio
# KNative
Expand Down

0 comments on commit 681709e

Please sign in to comment.