Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.2 manifests #1100

Merged
merged 2 commits into from
Apr 10, 2020
Merged

v1.0.2 manifests #1100

merged 2 commits into from
Apr 10, 2020

Conversation

richardsliu
Copy link
Contributor

Part of kubeflow/kubeflow#4929

I am pinning the manifests to v1.0-branch head for now. When we have cut a release (i.e. created a tag), I will update this again.

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

abhi-g
abhi-g reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@abhi-g abhi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jeffwan
Copy link
Member

Jeffwan commented Apr 10, 2020 •
edited
Loading

AWS changes looks good to me. We have one change here need to update v1.0.2 manifest.
#1041 . Waiting for this to be merged first

@richardsliu
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8add111 into kubeflow:master Apr 10, 2020
k8s-ci-robot pushed a commit that referenced this pull request Apr 11, 2020
@richardsliu
Automated cherry pick of #1100: v1.0.2 manifests Cherry pick of #1100 …
bb0535c 
…on v1.0-branch. #1100: v1.0.2 manifests (#1101)

* v1.0.2 manifests

* fix version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-g abhi-g abhi-g left review comments

@jlewi jlewi Awaiting requested review from jlewi

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

Assignees

@abhi-g abhi-g

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardsliu @kubeflow-bot @Jeffwan @k8s-ci-robot @abhi-g @googlebot