Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick "fix(gcp): default workload identity bindings (#1317)" #1331

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 28, 2020

Which issue is resolved by this Pull Request:
Part of GoogleCloudPlatform/kubeflow-distribution#61

* fix(gcp): default workload identity bindings

* update test snapshots
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@Bobgy Bobgy changed the base branch from master to v1.1-branch June 28, 2020 01:35
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2020

/assign @jlewi

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 29, 2020

/approve

Because this is a cherrypick, I'll ask @rmgogogo for lgtm

@rmgogogo
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rmgogogo
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit d858c47 into kubeflow:v1.1-branch Jun 29, 2020
@Bobgy Bobgy deleted the cp_1317 branch June 29, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants