-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more examples #2103
Adding more examples #2103
Conversation
Hi @missingcharacter. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @elikatsis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: missingcharacter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion |
And you need to fix the merge conflict first. |
/close since there is no response since August 25. |
@juliusvonkohout: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I am ok with closing this |
Which issue is resolved by this Pull Request:
Resolves None that I'm aware
Description of your changes:
example
toexamples
examples/all-included
external-dbs
I recently stood up kubeflow in multiple environments and noticed
I would have had spent less time standing up kubeflow if I had seen
more examples.
I thought the project would benefit from having different examples
that people can learn from.
Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-only
make test