Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more examples #2103

Closed
wants to merge 2 commits into from
Closed

Adding more examples #2103

wants to merge 2 commits into from

Conversation

missingcharacter
Copy link

@missingcharacter missingcharacter commented Jan 18, 2022

Which issue is resolved by this Pull Request:
Resolves None that I'm aware

Description of your changes:

  • Rename folder example to examples
  • Rename current example to examples/all-included
  • Created new example called external-dbs

I recently stood up kubeflow in multiple environments and noticed
I would have had spent less time standing up kubeflow if I had seen
more examples.

I thought the project would benefit from having different examples
that people can learn from.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@aws-kf-ci-bot
Copy link

Hi @missingcharacter. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@missingcharacter
Copy link
Author

/assign @elikatsis

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: missingcharacter
To complete the pull request process, please ask for approval from elikatsis after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

@juliusvonkohout
Copy link
Member

And you need to fix the merge conflict first.

@juliusvonkohout
Copy link
Member

/close

since there is no response since August 25.

Copy link

@juliusvonkohout: Closed this PR.

In response to this:

/close

since there is no response since August 25.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Nov 29, 2023
@missingcharacter
Copy link
Author

I am ok with closing this
@juliusvonkohout, sorry, I don't have free time to continue maintaining this fork. Thanks for the consideration

@missingcharacter missingcharacter deleted the examples branch November 29, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants