Set ENABLE_LEGACY_FSGROUP_INJECTION to false for istio

[bigflood]

remove unnecessary fsGroup ans its side effect.

Which issue is resolved by this Pull Request:
Resolves #2218

On kubernetes 1.19+, ENABLE_LEGACY_FSGROUP_INJECTION is not required.
istio 1.11~1.13 sets ENABLE_LEGACY_FSGROUP_INJECTION to true by default.

FYI, below are the versions supported in Kubeflow 1.5

• Kubernetes 1.21, 1.20, 1.19
• istio 1.11

istio/istio#27367
istio/istio#26882

Checklist:

• Unit tests pass:
  Make sure you have installed kustomize == 3.2.1
  1. make generate-changed-only
  2. make test

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigflood
To complete the pull request process, please assign yanniszark after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

[ozen]

Unnecessary fsGroup setting also prevents using defaultMode in volumes as mentioned in k8s docs and in the following issue: kubernetes/kubernetes#57923

[juliusvonkohout]

@ozen @bigflood is this still relevant? Please fix the branch conflict or create a new PR. Otherwise i have to close the PR.

[kimwnasptd]

Could we also have a minimal list of steps to reproduce the problem described in this PR?

[aqeelat]

@juliusvonkohout I don't think this is needed anymore because the flag is only needed to support K8s <= 1.18 which are not supported by the current version of kubeflow. Also, the flag was removed in istio 1.19.

source

[juliusvonkohout]

THanks @aqeelat
/close

[google-oss-prow]

@juliusvonkohout: Closed this PR.

In response to this:

TTHanks @aqeelat
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.