Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace arrikto/kubeflow container registry with kubeflowmanifestswg #2521

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Sep 4, 2023

Use the kubeflow manifests WG mirrored container images for pulling oidc-authservice.

Which issue is resolved by this Pull Request:
Part of #2469

Description of your changes:
Mirrored the gcr.io/arrikto/kubeflow/oidc-authservice:e236439 over to docker.io/kubeflowmanifestswg/oidc-authservice:e236439

cc: @kimwnasptd @annajung

Copy link
Member

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DnPlas left some small comments. High overview is that we only need to update the newName, and let name match the previous value in the image transformer.

Take also a look on how this is done in #2481 or #2480

@@ -42,6 +42,6 @@ vars:
configurations:
- params.yaml
images:
- name: gcr.io/arrikto/kubeflow/oidc-authservice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll only need to update the newName key with the dockerhub registry, and make sure the name matches what is initially in the StatefulSet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks!

@@ -18,7 +18,7 @@ spec:
serviceAccountName: authservice
containers:
- name: authservice
image: gcr.io/arrikto/kubeflow/oidc-authservice:e236439
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to not touch this at all, in order for the image transformer to use name and detect the old arrikto image and then newName to convert to the new name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks!

@DnPlas DnPlas force-pushed the dnplas-replace-oidc-authservice-registry branch from af06176 to ce69821 Compare September 5, 2023 21:50
…estswg

Use the kubeflow manifests WG mirrored container images for pulling oidc-authservice.

Part of kubeflow#2469
@DnPlas DnPlas force-pushed the dnplas-replace-oidc-authservice-registry branch from ce69821 to 28d90be Compare September 5, 2023 21:51
@annajung
Copy link
Member

annajung commented Sep 6, 2023

/lgtm

@DnPlas
Copy link
Contributor Author

DnPlas commented Sep 7, 2023

/assign @kimwnasptd

could I ask for your approval so we can merge?

@kimwnasptd
Copy link
Member

thanks!

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DnPlas, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c43feba into kubeflow:master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants