-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace arrikto/kubeflow container registry with kubeflowmanifestswg #2521
chore: replace arrikto/kubeflow container registry with kubeflowmanifestswg #2521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -42,6 +42,6 @@ vars: | |||
configurations: | |||
- params.yaml | |||
images: | |||
- name: gcr.io/arrikto/kubeflow/oidc-authservice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll only need to update the newName
key with the dockerhub registry, and make sure the name
matches what is initially in the StatefulSet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, thanks!
@@ -18,7 +18,7 @@ spec: | |||
serviceAccountName: authservice | |||
containers: | |||
- name: authservice | |||
image: gcr.io/arrikto/kubeflow/oidc-authservice:e236439 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to not touch this at all, in order for the image transformer to use name
and detect the old arrikto image and then newName
to convert to the new name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, thanks!
af06176
to
ce69821
Compare
…estswg Use the kubeflow manifests WG mirrored container images for pulling oidc-authservice. Part of kubeflow#2469
ce69821
to
28d90be
Compare
/lgtm |
/assign @kimwnasptd could I ask for your approval so we can merge? |
thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DnPlas, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use the kubeflow manifests WG mirrored container images for pulling oidc-authservice.
Which issue is resolved by this Pull Request:
Part of #2469
Description of your changes:
Mirrored the
gcr.io/arrikto/kubeflow/oidc-authservice:e236439
over todocker.io/kubeflowmanifestswg/oidc-authservice:e236439
cc: @kimwnasptd @annajung