-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: istio 1.70 envoy filter chain should be changed. #2656
Conversation
@cybernagle you need to sign with DCO |
Signed-off-by: Nagle Zhang <[email protected]>
@juliusvonkohout DCO signed. :) |
oidc-authservice is deprecated, but lets get this in anyway. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybernagle, juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juliusvonkohout |
@cybernagle oauth2-proxy is already the default in the master branch. You might want to join the manifests and security wg meetings to stay up to date. Please also join the slack channels wg-manifests and security https://www.kubeflow.org/docs/about/community/ |
Signed-off-by: Nagle Zhang <[email protected]>
Which issue is resolved by this Pull Request:
Resolves in latest version of istio , the authn-filter may not work becuase of filterChain
envoy.http_connection_manager
is deactived, and changed it toenvoy.filters.network.http_connection_manager
Description of your changes:
https://istio.io/latest/docs/reference/config/networking/envoy-filter/#EnvoyFilter-ListenerMatch-FilterChainMatch
Checklist:
Make sure you have installed kustomize == 5.0.3
make generate-changed-only
make test