Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: istio 1.70 envoy filter chain should be changed. #2656

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

cybernagle
Copy link
Contributor

Which issue is resolved by this Pull Request:

Resolves in latest version of istio , the authn-filter may not work becuase of filterChain envoy.http_connection_manager is deactived, and changed it to envoy.filters.network.http_connection_manager

Description of your changes:
https://istio.io/latest/docs/reference/config/networking/envoy-filter/#EnvoyFilter-ListenerMatch-FilterChainMatch

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.0.3
    1. make generate-changed-only
    2. make test

@juliusvonkohout
Copy link
Member

@cybernagle you need to sign with DCO

@cybernagle
Copy link
Contributor Author

@juliusvonkohout DCO signed. :)

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 3, 2024

oidc-authservice is deprecated, but lets get this in anyway.

@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybernagle, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c1a8c7d into kubeflow:master Apr 3, 2024
4 checks passed
@cybernagle cybernagle deleted the patch-1 branch April 9, 2024 02:26
@cybernagle
Copy link
Contributor Author

cybernagle commented Apr 9, 2024

oidc-authservice is deprecated, but lets get this in anyway.

@juliusvonkohout
thank you for your information , May I ask what is the alternative of oidc-authservice ? or do you have any document to describe such deprecation? thank you very much :)

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 9, 2024

@cybernagle oauth2-proxy is already the default in the master branch. You might want to join the manifests and security wg meetings to stay up to date. Please also join the slack channels wg-manifests and security https://www.kubeflow.org/docs/about/community/

doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants