-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also use hashFromEnv for oauth2-proxy overlay #2669
Conversation
Same as cd991e6 Signed-off-by: Alexander Block <[email protected]>
I deployed this on kind + WSL on my local environment. I confirm the Thanks for taking care of this. |
/hold CC @diegolovison since we might need to update the main readme.md documentation. |
Hi. I am not familiar with that code change. In the readme there are 3 entries with What exactly this code is changing? |
@diegolovison it's about referencing the same value from env instead of providing as plaintext. It's more secure. Please see: |
The values are matching. I believe we don't need to change the readme |
cd991e6 helped a lot with the decision :-D /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codablock, juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Same as cd991e6 Signed-off-by: Alexander Block <[email protected]>
Description of your changes:
Same as cd991e6
Checklist:
Make sure you have installed kustomize == 5.2.1+
make generate-changed-only
make test