-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with linting of YAML files #2825
fix issue with linting of YAML files #2825
Conversation
@juliusvonkohout I fix the mistake. Before merge #2815, I think we need to merge this to master and sync this change with that PR. |
@@ -71,7 +71,7 @@ jobs: | |||
- name: Set up changed files | |||
id: changed_files | |||
run: | | |||
git diff --name-status origin/master...HEAD | grep -E '^[AM].*\.(yaml|yml)$' | awk '{print $2}' > changed_files_in_PR.txt || true | |||
git diff --name-status origin/master...HEAD | grep -E '^[AM].*\/(common|example)\/.*\.(yaml|yml)$' | awk '{print $2}' > changed_files_in_PR.txt || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain a bit? doe sthis only check /common/* and /example/* for now? That would be a massive downgrade. there is also .gtihub and some other folders that should be checked. Can you create variable with the list of folders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. as I remember Before we discussed doing that. That's why I added It. Any concerns regarding that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please add .github and tests and hack next to common and example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add those files as well
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
615aebb
to
122eed1
Compare
Signed-off-by: hansinikarunarathne <[email protected]>
This is not working properly. I see
but you clearly changed yaml files here. |
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
fixed the issue |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]>
* fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]>
* Training operator CICD improvements (#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]>
* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]>
* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]>
* fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: Patrick Schönthaler <[email protected]>
* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]> Signed-off-by: Patrick Schönthaler <[email protected]>
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCO
check)cla/google
check)