remove seldon, bentoml and metacontroller (included in upstream KFP) #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juliusvonkohout <[email protected]>
google-oss-prow
bot
requested review from
gkcalat,
kimwnasptd and
TobiasGoerke
Signed-off-by: juliusvonkohout <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
juliusvonkohout
requested review from
andreyvelich
and removed request for
TobiasGoerke and
gkcalat
|
/lgtm |
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andreyvelich
"I am fine with removing seldon, metacontroller, and bentoml. Metacontroller should anyway be in the pipelines manifest. I want to explicitly keep spark, ray, security and seaweedfs as experiments. Spark and Ray need special integration glue for Kubeflow, they are not just the spark/ray upstream manifests. I can also move kserve to the applications folder. Maybe just renaming /contrib to /experimental as staging/incubation area is enough. I can also create a PR for this.
Ray targets other usecases and it is in contrib/experimental. I got actual code contributions from users there. Ray and MLflow are typical things requested by users. If they are interested they can try it out, but it is disabled by default. So i think that it is a valuable addition that belongs to the experiments folder. If distributions want to refine and include the experiments from that folder that is a good thing, if not that is also fine. In the end as manifests WG we need this experiments folder to try out stuff and gather user feedback."