Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Istio to v1.24.2 #2950

Merged
merged 9 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/kserve_cni_test.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Build & Apply KServe manifests in KinD, using istio CNI
on:

Check warning on line 2 in .github/workflows/kserve_cni_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
- .github/workflows/kserve_cni_test.yaml
- common/istio-cni-1-23/**
- common/istio-cni-1-24/**
- tests/gh-actions/install_cert_manager.sh
- common/cert-manager/**
- tests/gh-actions/install_knative-cni.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notebook_controller_m2m_test.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Test Notebook Controller with m2m auth manifests in KinD
on:

Check warning on line 2 in .github/workflows/notebook_controller_m2m_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -34,7 +34,7 @@
run: ./tests/gh-actions/install_oauth2-proxy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-1-24/kubeflow-istio-resources/base | kubectl apply -f -

- name: Install KF Multi Tenancy
run: ./tests/gh-actions/install_multi_tenancy.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pipeline_run_from_notebook.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Create Pipeline Run from Kubeflow Notebook
on:

Check warning on line 2 in .github/workflows/pipeline_run_from_notebook.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -37,7 +37,7 @@
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-1-24/kubeflow-istio-resources/base | kubectl apply -f -

- name: Install KF Pipelines
run: ./tests/gh-actions/install_pipelines.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pipeline_swfs_test.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Deploy and test Kubeflow Pipelines manifests with seaweedfs and m2m auth in KinD
on:

Check warning on line 2 in .github/workflows/pipeline_swfs_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -45,7 +45,7 @@
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-1-24/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pipeline_test.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Deploy and test Kubeflow Pipelines manifests with m2m auth in KinD
on:

Check warning on line 2 in .github/workflows/pipeline_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -44,7 +44,7 @@
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-1-24/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pss_test.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Apply PSS labels to namespaces
on:

Check warning on line 2 in .github/workflows/pss_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -51,7 +51,7 @@
run: kustomize build common/kubeflow-namespace/base | kubectl apply -f -

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-cni-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-cni-1-24/kubeflow-istio-resources/base | kubectl apply -f -

- name: Install KF Multi Tenancy
run: ./tests/gh-actions/install_multi_tenancy.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/training_operator_test.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Build & Apply Training Operator manifests in KinD
on:

Check warning on line 2 in .github/workflows/training_operator_test.yaml

View workflow job for this annotation

GitHub Actions / format_YAML_files

2:1 [truthy] truthy value should be one of [false, true]
pull_request:
paths:
- tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh
Expand Down Expand Up @@ -38,7 +38,7 @@
run: ./tests/gh-actions/install_multi_tenancy.sh

- name: Install kubeflow-istio-resources
run: kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
run: kustomize build common/istio-1-24/kubeflow-istio-resources/base | kubectl apply -f -

- name: Create KF Profile
run: kustomize build common/user-namespace/base | kubectl apply -f -
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ used from the different projects of Kubeflow:

| Component | Local Manifests Path | Upstream Revision |
| - | - | - |
| Istio | common/istio-1-23 | [1.23.2](https://github.com/istio/istio/releases/tag/1.23.2) |
| Istio | common/istio-1-24 | [1.24.2](https://github.com/istio/istio/releases/tag/1.24.2) |
| Knative | common/knative/knative-serving <br /> common/knative/knative-eventing | [v1.16.0](https://github.com/knative/serving/releases/tag/knative-v1.16.0) <br /> [v1.16.1](https://github.com/knative/eventing/releases/tag/knative-v1.16.1) |
| Cert Manager | common/cert-manager | [1.16.1](https://github.com/cert-manager/cert-manager/releases/tag/v1.16.1) |

Expand Down Expand Up @@ -211,9 +211,9 @@ Install Istio:

```sh
echo "Installing Istio configured with external authorization..."
kustomize build common/istio-1-23/istio-crds/base | kubectl apply -f -
kustomize build common/istio-1-23/istio-namespace/base | kubectl apply -f -
kustomize build common/istio-1-23/istio-install/overlays/oauth2-proxy | kubectl apply -f -
kustomize build common/istio-1-24/istio-crds/base | kubectl apply -f -
kustomize build common/istio-1-24/istio-namespace/base | kubectl apply -f -
kustomize build common/istio-1-24/istio-install/overlays/oauth2-proxy | kubectl apply -f -

echo "Waiting for all Istio Pods to become ready..."
kubectl wait --for=condition=Ready pods --all -n istio-system --timeout 300s
Expand Down Expand Up @@ -343,7 +343,7 @@ Install Knative Serving:

```sh
kustomize build common/knative/knative-serving/overlays/gateways | kubectl apply -f -
kustomize build common/istio-1-23/cluster-local-gateway/base | kubectl apply -f -
kustomize build common/istio-1-24/cluster-local-gateway/base | kubectl apply -f -
```

Optionally, you can install Knative Eventing which can be used for inference request logging:
Expand Down Expand Up @@ -390,7 +390,7 @@ Create the Kubeflow Gateway, `kubeflow-gateway` and ClusterRole,
Install kubeflow istio resources:

```sh
kustomize build common/istio-1-23/kubeflow-istio-resources/base | kubectl apply -f -
kustomize build common/istio-1-24/kubeflow-istio-resources/base | kubectl apply -f -
```

#### Kubeflow Pipelines
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ kind: ServiceAccount
metadata:
labels:
app: cluster-local-gateway
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio: cluster-local-gateway
istio.io/rev: default
Expand All @@ -16,6 +22,12 @@ kind: Deployment
metadata:
labels:
app: cluster-local-gateway
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio: cluster-local-gateway
istio.io/rev: default
Expand All @@ -42,7 +54,13 @@ spec:
sidecar.istio.io/inject: 'false'
labels:
app: cluster-local-gateway
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
chart: gateways
helm.sh/chart: istio-ingress-1.24.2
heritage: Tiller
install.operator.istio.io/owning-resource: unknown
istio: cluster-local-gateway
Expand Down Expand Up @@ -109,7 +127,8 @@ spec:
- name: ISTIO_META_WORKLOAD_NAME
value: cluster-local-gateway
- name: ISTIO_META_OWNER
value: kubernetes://apis/apps/v1/namespaces/istio-system/deployments/cluster-local-gateway
value:
kubernetes://apis/apps/v1/namespaces/istio-system/deployments/cluster-local-gateway
- name: ISTIO_META_MESH_ID
value: cluster.local
- name: TRUST_DOMAIN
Expand All @@ -122,7 +141,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: spec.nodeName
image: docker.io/istio/proxyv2:1.23.2
image: docker.io/istio/proxyv2:1.24.2
name: istio-proxy
ports:
- containerPort: 15020
Expand Down Expand Up @@ -235,6 +254,12 @@ kind: PodDisruptionBudget
metadata:
labels:
app: cluster-local-gateway
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio: cluster-local-gateway
istio.io/rev: default
Expand All @@ -253,6 +278,12 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
labels:
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio.io/rev: default
operator.istio.io/component: IngressGateways
Expand All @@ -273,6 +304,12 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
labels:
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio.io/rev: default
operator.istio.io/component: IngressGateways
Expand All @@ -292,6 +329,12 @@ kind: HorizontalPodAutoscaler
metadata:
labels:
app: cluster-local-gateway
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio: cluster-local-gateway
istio.io/rev: default
Expand Down Expand Up @@ -320,6 +363,12 @@ metadata:
annotations:
labels:
app: cluster-local-gateway
app.kubernetes.io/instance: istio
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: istio-ingressgateway
app.kubernetes.io/part-of: istio
app.kubernetes.io/version: 1.24.2
helm.sh/chart: istio-ingress-1.24.2
install.operator.istio.io/owning-resource: unknown
istio: cluster-local-gateway
istio.io/rev: default
Expand All @@ -331,11 +380,9 @@ spec:
ports:
- name: status-port
port: 15020
protocol: TCP
targetPort: 15020
- name: http2
port: 80
protocol: TCP
targetPort: 8080
selector:
app: cluster-local-gateway
Expand Down
Loading
Loading