-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing loadBalancerScheme issue in ingress annotation #952
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @PatrickXYS. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Jeffwan |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…961) * Create overlay allowing the Load Balancer to be created with HTTPS with it handling no auth. Additionally making the scheme (internet facing/internal) configurable and adding external-dns annotation for clusters with it installed. Cleaned up some duplicated annotations as well (#653) * Upgrade aws component version (#890) * Upgrade aws components versions for v1.0 * Update tests for aws components * Add policy profile controller plugin need (#917) * Add external mysql option for pipeline and metadata (#906) * Add OWNERS file under test folder (#947) * Fixing loadBalancerScheme issue in ingress annotation (#952) * Fix AWS OIDC settings (#953)
Which issue is resolved by this Pull Request:
Resolves #946
Description of your changes:
Fixing loadBalancerScheme issue in ingress annotation.
loadBalancerScheme
was introduced in the base manifest but there's noparams.yaml
for base and annotation doesn't get updated. no-authkfctl_aws.yaml
is affected. Thus, I added oneparams.yaml
and modifiedkustomization.yaml
file.Checklist:
cd manifests/tests
make generate-changed-only
make test
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)