-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial commit for UI #108 #114
feat: Initial commit for UI #108 #114
Conversation
In this commit: - basic Dockerfile - basic Makefile - Scaffold of App and first sample endpoint (http://localhost:4000/api/v1/healthcheck/) - REST API basic infrastructure and error handling Signed-off-by: Eder Ignatowicz <[email protected]>
9727051
to
cafc660
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarilabs thank you so much for the review! I'll send it on a FUP PR as soon as possible. |
got it, works for me /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this commit: - basic Dockerfile - basic Makefile - Scaffold of App and first sample endpoint (http://localhost:4000/api/v1/healthcheck/) - REST API basic infrastructure and error handling Signed-off-by: Eder Ignatowicz <[email protected]> Signed-off-by: muzhouliu <[email protected]>
[pull] main from kubeflow:main
The initial commit for UI, as discussed at #108.
Description
In this commit:
How Has This Been Tested?
Merge criteria: