Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Update disabled dropdown styling to match with KF #775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenny-s51
Copy link
Contributor

Description

Updates Model Registry and Namespace selector to match with MUI theming.

Before:
Screenshot 2025-02-07 at 3 21 38 PM

After:
Screenshot 2025-02-07 at 3 22 14 PM

Kubeflow Disabled Namespace selector:
Screenshot 2025-02-07 at 3 39 16 PM

MUI Disabled Select:
Screenshot 2025-02-07 at 3 44 41 PM

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: syntaxsdev
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jenny <[email protected]>

fix(frontend): revert disabled state

revert kustomization files

Signed-off-by: Jenny <[email protected]>

format with prettier
@jenny-s51 jenny-s51 force-pushed the disabled-dropdowns-fix branch from 3c9326e to 3ab2f66 Compare February 10, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants