Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependabot spec for python client #78

Merged
merged 1 commit into from
May 13, 2024

Conversation

isinyaaa
Copy link
Contributor

@isinyaaa isinyaaa commented May 9, 2024

directory should point to manifest location 1, which is the pyproject.toml file in our case 2.

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We setup using root directory as the dependabot can already recursively scan, but doesn't hurt we make this entry specific and in case we'll have an additional python project in this repo we could add an additional .github/dependabot.yml entry with again a specific dir.

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1f75cac into kubeflow:main May 13, 2024
7 checks passed
@isinyaaa isinyaaa deleted the pip-dependabot branch May 13, 2024 12:36
isinyaaa added a commit to isinyaaa/model-registry that referenced this pull request Jun 27, 2024
GHA: require codecov token explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants