-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors gracefully on routes #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @isinyaaa for this PR,
let me know if the comment below you want to do it as part of this PR or future PR
Do we want to do anything with left over "todo" comments? if no further steps we are going to like 401 ones which get intercepted at filter level, can we remove them? |
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
I'd advise to manage the TODOs as follow-up PR, so to keep the scope of this PR to start consolidating repeated code, while "debt" to be managed separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @isinyaaa thank you for the quick loop, I'd say we merge this and we track the TODO for the auth in a single filter in a subsequent PR; reason is I would like to parallelize work since a reported issue (#95 ) could then investigated in parallel better with this one merged already so we set a baseline
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
periodic sync upstream KF to midstream ODH
Description
This fixes an unhandled error on the GetEnvironmentEnvironments route, as well as standardizes error value treatment using an error to http status converter. All status codes now use the standard net/http consts (enum).
How Has This Been Tested?
Tested with
make test
.Merge criteria: