feat!: Use Argo Emissary Executor instead of Docker by default. Partial

#5718 (#7137) * feat!: Use Argo Emissary Executor instead of docker by default. * marketplace presubmit
kubeflow · Jan 10, 2022 · bea751c · bea751c
1 parent f3a1b65
commit bea751c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml b/manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml
@@ -18,7 +18,7 @@ images:
   cachedeployer: gcr.io/ml-pipeline/google/pipelines/cachedeployer:dummy
 
 executor:
-  emissary: false
+  emissary: true
 gcpDefaultConfigName: "gcp-default-config"
 managedstorage:
   enabled: false

diff --git a/manifests/gcp_marketplace/test/snapshot-base.yaml b/manifests/gcp_marketplace/test/snapshot-base.yaml
@@ -12,7 +12,7 @@ metadata:
 data:
   appName: 'my-release'
   namespace: 'kubeflow'
-  emissaryExecutor: 'false'
+  emissaryExecutor: 'true'
   managedStorageEnabled: 'false'
   #
 ---
@@ -831,7 +831,7 @@ data:
   # * https://github.com/argoproj/argo-workflows/blob/v3.2.3/docs/workflow-controller-configmap.yaml
 
   # emissary executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
-  containerRuntimeExecutor: 'docker'
+  containerRuntimeExecutor: 'emissary'
 
   # Note, some-string-{{without}}-template-interpretation is a way to avoid some brackets interpreted as template.
   # Reference: https://github.com/helm/helm/issues/2798#issuecomment-467319526

diff --git a/manifests/gcp_marketplace/test/snapshot-managed-storage-with-db-prefix.yaml b/manifests/gcp_marketplace/test/snapshot-managed-storage-with-db-prefix.yaml
@@ -12,7 +12,7 @@ metadata:
 data:
   appName: 'my-release'
   namespace: 'kubeflow'
-  emissaryExecutor: 'false'
+  emissaryExecutor: 'true'
   managedStorageEnabled: 'true'
   #
   managedStorageCloudSqlInstanceConnectionName: 'myproject:us-central1:myinstance'
@@ -889,7 +889,7 @@ data:
   # * https://github.com/argoproj/argo-workflows/blob/v3.2.3/docs/workflow-controller-configmap.yaml
 
   # emissary executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
-  containerRuntimeExecutor: 'docker'
+  containerRuntimeExecutor: 'emissary'
 
   # Note, some-string-{{without}}-template-interpretation is a way to avoid some brackets interpreted as template.
   # Reference: https://github.com/helm/helm/issues/2798#issuecomment-467319526

diff --git a/manifests/gcp_marketplace/test/snapshot-managed-storage.yaml b/manifests/gcp_marketplace/test/snapshot-managed-storage.yaml
@@ -12,7 +12,7 @@ metadata:
 data:
   appName: 'my-release'
   namespace: 'kubeflow'
-  emissaryExecutor: 'false'
+  emissaryExecutor: 'true'
   managedStorageEnabled: 'true'
   #
   managedStorageCloudSqlInstanceConnectionName: 'myproject:us-central1:myinstance'
@@ -889,7 +889,7 @@ data:
   # * https://github.com/argoproj/argo-workflows/blob/v3.2.3/docs/workflow-controller-configmap.yaml
 
   # emissary executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
-  containerRuntimeExecutor: 'docker'
+  containerRuntimeExecutor: 'emissary'
 
   # Note, some-string-{{without}}-template-interpretation is a way to avoid some brackets interpreted as template.
   # Reference: https://github.com/helm/helm/issues/2798#issuecomment-467319526

diff --git a/manifests/kustomize/third-party/argo/base/workflow-controller-configmap-patch.yaml b/manifests/kustomize/third-party/argo/base/workflow-controller-configmap-patch.yaml
@@ -9,7 +9,7 @@ data:
   # * https://github.com/argoproj/argo-workflows/blob/v3.2.3/docs/workflow-controller-configmap.yaml
 
   # emissary executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
-  containerRuntimeExecutor: docker
+  containerRuntimeExecutor: executor
 
   # In artifactRepository.s3.endpoint, $(kfp-namespace) is needed, because in multi-user mode, pipelines may run in other namespaces.
   artifactRepository: |