Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using user-gcp-sa creds for a pipeline step appears to prevent creating cluster resources from that pod #705

Closed
amygdala opened this issue Jan 18, 2019 · 4 comments
Assignees
Labels
area/kfctl kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p2

Comments

@amygdala
Copy link
Contributor

amygdala commented Jan 18, 2019

It looks like any pipeline step pod that needs to create a new service, deployment, etc. will throw a permissions error that the kf 'user' account (<deployment_name>-user@) doesn't have the rights to do "container.services.create", "container.deployments.create", etc.) if the pod is using gcp auth via the .apply(gcp.use_gcp_secret('user-gcp-sa')) call for that step when the pipeline is defined. Without the gcp creds attached, it can create the service successfully.

Adding the "Kubernetes Engine Admin" role to that kf user account fixes the issue.
I guess that might mean that the gcp creds in this case are less permissive than the non-gcp-credentials state?
I'd argue that use of the gcp creds shouldn't prevent creating new cluster resources.

(This may be more a core kf issue... feel free to re-categorize)

@paveldournov
Copy link
Contributor

Thanks for reporting, @amygdala, this is good suggestion.

@Ark-kun - PTAL, should we be adding the K8s admin to the gcp-sa account automatically?

@amygdala
Copy link
Contributor Author

One 'gotcha' scenario if we don't do this: I could see people wanting to just blanket apply
.apply(gcp.use_gcp_secret('user-gcp-sa'))
to all their pipeline steps when they know the pipeline is running on GKE, but any step which tries to launch a tf-serving pod (etc.) will then fail.

@stale
Copy link

stale bot commented Jun 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 25, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 3, 2020
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kfctl kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p2
Projects
None yet
Development

No branches or pull requests

6 participants