Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Remote Build Execution for Bazel builds. #1031

Merged
merged 17 commits into from
Sep 30, 2019
Merged

Use Remote Build Execution for Bazel builds. #1031

merged 17 commits into from
Sep 30, 2019

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Mar 24, 2019 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from IronPan and vicaire March 24, 2019 20:22
@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

3 similar comments
@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage neuromage changed the title [WIP] Use Remote Build Execution for Bazel builds. Use Remote Build Execution for Bazel builds. Apr 11, 2019
@neuromage
Copy link
Contributor Author

This is now ready to be looked at.

/assign @IronPan

@neuromage
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

@IronPan friendly ping

@neuromage
Copy link
Contributor Author

@IronPan can you take a look at this one please? Thanks.

@neuromage
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 5, 2019
@neuromage
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@neuromage: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neuromage
Copy link
Contributor Author

/retest

@IronPan
Copy link
Member

IronPan commented Jun 6, 2019

/lgtm

@IronPan
Copy link
Member

IronPan commented Jun 6, 2019

/test kubeflow-pipeline-e2e-test

@neuromage
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 1, 2019
IronPan
IronPan reviewed Jul 18, 2019
View reviewed changes
tools/bazel_builder/OWNERS Outdated
approvers:
- neuromage
- IronPan
- vicaire
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@IronPan
Copy link
Member

IronPan commented Jul 18, 2019

/approve

@IronPan
Copy link
Member

IronPan commented Jul 18, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 3, 2019

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 20, 2019

@neuromage Shall we merge this?

@neuromage
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neuromage
Copy link
Contributor Author

Thanks @Ark-kun! Yes, we should merge it.

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 4, 2019

Thanks @Ark-kun! Yes, we should merge it.

AFAIK, You've put this PR on hold some time ago.

@k8s-ci-robot k8s-ci-robot merged commit a882999 into kubeflow:master Sep 30, 2019
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Update pipelinerun timeout format to timeouts (kubeflow#1031)
aa3366f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan IronPan left review comments

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@IronPan IronPan

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neuromage @IronPan @k8s-ci-robot @Ark-kun