Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bigquery component to export to table only #1062

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Allow bigquery component to export to table only #1062

merged 1 commit into from
Mar 30, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 29, 2019 •
edited by jlewi
Loading

The PR includes changes:

  • Removes the code to dump results to local disk, as there is no any requirement for it,
  • Dumps dataset_id and table_id so it can be orchestrate in subsequent steps.
  • Only set job_config default value if it's not provided. This gives user the chance to change it as needed.

This change is Reviewable

gaoning777
gaoning777 reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hongye-sun
Copy link
Contributor Author

Thanks.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor Author

/retest

3 similar comments
@hongye-sun
Copy link
Contributor Author

/retest

@hongye-sun
Copy link
Contributor Author

/retest

@hongye-sun
Copy link
Contributor Author

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 30, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit d626d06 into kubeflow:master Mar 30, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@riklopfer @animeshsingh
document working k8s version (kubeflow#1062)
816d3cb 
* ensure working k8s version

* Update hack/quick_install.sh

Co-authored-by: Animesh Singh <[email protected]>

Co-authored-by: Animesh Singh <[email protected]>
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
chore(sdk): Remove unnecessary code (kubeflow#1062)
9b9b932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @k8s-ci-robot @Ark-kun @gaoning777